Fix auth_app for modern Taiga versions - #269
Open
yakky wants to merge 3 commits into
Open
Conversation
- Reclassify the changelog fragment for #227 as a breaking change, removal type, instead of a bugfix, since auth_app's signature and return value both changed. - Document the new auth_app flow in docs/usage.rst. - Add coverage for the 200-response-without-token error branch. - Version bump to 2.0.0 is left to the release process, per review on #229. Co-authored-by: Melissa Eckardt <melissa.eckardt@gdata-adan.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 96.47% 97.29% +0.81%
==========================================
Files 8 8
Lines 936 923 -13
Branches 67 64 -3
==========================================
- Hits 903 898 -5
+ Misses 19 15 -4
+ Partials 14 10 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 tasks
|
coverage: 98.375% (+0.4%) from 97.97% — removal/227-fix-app-auth into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #229 (rebased onto current master + packaged as a breaking change per review). Fixes #227, fixes #189.
Original fix by @meck-gd — see #229 for the full discussion. This branch adds: