fix: emit React Native border-start/end props for border-inline styles#379
Open
danstepanov wants to merge 1 commit into
Open
fix: emit React Native border-start/end props for border-inline styles#379danstepanov wants to merge 1 commit into
danstepanov wants to merge 1 commit into
Conversation
border-inline-start-color and friends compiled to props like borderInlineStartColor that React Native does not support, so every border-s-* and border-e-* utility was a silent no-op on native. Rename them to the RTL-aware border-start-* and border-end-* props in both the parsed and unparsed paths, fix the border-inline shorthands, and drop per-side border styles (with a compiler warning when the style is not solid, since solid matches the native default). Dev builds now print compiler warnings from the metro transformer so declarations without a native equivalent are visible while building. Closes #378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #378, follow up to nativewind/nativewind#1737.
What
border-inline-start-color, border-inline-end-color, and the width and shorthand variants compiled to props like borderInlineStartColor that React Native does not have, so every border-s-* and border-e-* utility (and border-x-, which Tailwind v4 also emits as border-inline-) was a silent no-op on native.
border-s-*andborder-e-*don't work nativewind#1737 report).Tests