PYTHON-5977 APM/logging hot-path optimizations - #2968
Draft
NoahStapp wants to merge 5 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5977
Changes in this PR
The changes introduced by PYTHON-5903, PYTHON-5846, PYTHON-5745, and PYTHON-5676 caused small but measurable regressions for low-latency, high operation count workloads such as the DSI locust_ping benchmark. Much of this is due to constructing telemetry objects even when APM/logging is disabled and other similar changes that lie on the hot path for such workloads.
This PR attempts to optimize all of those regressions away and return performance to its point before their addition.
Test Plan
Standard test suite, benchmarks.
Results of a simple ping workload benchmark:
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is there test coverage?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer