fix: read memory version from package.json, add missing zod deps - #4557
Open
Timelovers wants to merge 5 commits into
Open
fix: read memory version from package.json, add missing zod deps#4557Timelovers wants to merge 5 commits into
Timelovers wants to merge 5 commits into
Conversation
- Read serverInfo.version from package.json instead of hardcoding "0.6.3", so it stays in sync with the published package version - Add missing zod dependency to server-memory and server-sequential-thinking package.json files — both import zod at runtime but it was only available transitively through the SDK Fixes modelcontextprotocol#4406, fixes modelcontextprotocol#4330 Co-authored-by: Timelovers <46080686+Timelovers@users.noreply.github.com>
Co-authored-by: Timelovers <46080686+Timelovers@users.noreply.github.com>
Co-authored-by: Timelovers <46080686+Timelovers@users.noreply.github.com>
Co-authored-by: Timelovers <46080686+Timelovers@users.noreply.github.com>
createRequire is the standard Node.js ESM pattern for reading JSON files and avoids file path resolution issues in CI test environments. Co-authored-by: Timelovers <46080686+Timelovers@users.noreply.github.com>
Author
|
Hi — friendly ping. Let me know if any changes are needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4406, fixes #4330.
Two small fixes:
memory server version — reads
serverInfo.versionfrompackage.jsonat startup instead of hardcoding"0.6.3", so it stays in sync with the published package version.missing zod dependency —
zodis imported at runtime by bothserver-memoryandserver-sequential-thinkingbut was only available transitively through@modelcontextprotocol/sdk. With strict package managers (pnpm), this causesERR_MODULE_NOT_FOUNDat startup. Addedzod: "^3"to bothdependencies.