fix: conservatively retry legacy server initialization - #1045
Draft
tsarlandie-oai wants to merge 1 commit into
Draft
fix: conservatively retry legacy server initialization#1045tsarlandie-oai wants to merge 1 commit into
tsarlandie-oai wants to merge 1 commit into
Conversation
tsarlandie-oai
force-pushed
the
codex/rmcp-1040-safe-legacy-lifecycle
branch
2 times, most recently
from
July 27, 2026 22:34
d28b11d to
ed0762c
Compare
tsarlandie-oai
force-pushed
the
codex/rmcp-1040-safe-legacy-lifecycle
branch
from
July 27, 2026 22:42
ed0762c to
8629887
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientLifecycleMode::Autoown conservative modern-to-legacy lifecycle negotiationMETHOD_NOT_FOUND,INVALID_REQUEST, andINVALID_PARAMSresponsesid: nulland no supported-version listinitializeretry without fabricating a JSON-RPC responseDowngrade policy
Auto mode retries legacy initialization only when the discovery probe provides explicit legacy evidence:
-32601,-32600, or-32602responseAuthentication failures, unrelated response IDs, established-session errors, malformed or arbitrary errors, and unknown/mixed/future version evidence fail without downgrade.
Transport behavior
HttpStatusErrorcarries the original status and body independently of the HTTP backend. Valid JSON-RPC errors in an initial HTTP 400 continue through normal modern-version negotiation; raw prevalidation failures remain typed transport errors that Auto mode can inspect. When a downgrade is safe, Auto sends a real legacyinitializerequest through the still-live transport worker.Custom
StreamableHttpClientimplementations can participate by returningUnexpectedHttpStatus(HttpStatusError)for non-success discovery responses.Validation
cargo clippy -p rmcp --all-features --all-targets -- -D warningsThis is intended to let Codex remove its complete
legacy_discovery_fallback_responseworkaround while preserving deployed-server interoperability and downgrade safety.Fixes #1040