Cancel background task runners on server disposal#1715
Open
jstar0 wants to merge 2 commits into
Open
Conversation
Signed-off-by: King Star <mcxin.y@gmail.com>
jstar0
force-pushed
the
fix/server-lifetime-task-runners
branch
from
July 25, 2026 16:50
ff309e9 to
456f064
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background Tasks runners used cancellation sources independent of the owning
server and discarded their Task handles. As a result, server disposal could
finish before a runner was cancelled, including when the runner registered
during disposal.
Changes
extension infrastructure.
registration after request handlers drain, and await the remaining runners.
completed registrations.
independent requests.
and the stateless ownership boundary.
The change does not alter protocol messages, task-store contracts, polling, or
explicit tasks/cancel behavior.
Verification
The lifecycle focus passed on net10.0, net9.0, and net8.0 (3 tests on each
framework), with 20 additional consecutive net10.0 repetitions. The full Core
suite passed with 2312 passed and 5 skipped; the analyzer suite passed with 57
passed. The Release solution build completed with 0 warnings and 0 errors,
package validation produced all packages, and DocFX completed with 0 warnings
and 0 errors. NativeAOT publish and execution also completed successfully.
The ASP.NET conformance harness has one unrelated local baseline failure under
Node.js v26.5.0 in
elicitation-sep1330-enums; the exact currentmainrunreproduces the same failure, while the remaining ASP.NET suite passes with 583
passed and 30 skipped. The repository CI workflow uses Node.js 22.
Closes #1707