user: align Windows mkdir behavior with Unix#236
Open
thaJeztah wants to merge 1 commit into
Open
Conversation
The Windows implementation of mkdirAs was originally introduced as a minimal wrapper around os.MkdirAll because ownership is not supported on Windows and the uid/gid parameters were only needed to keep the daemon starting. As a result, MkdirAndChown would also create missing parent directories, unlike the Unix implementation. Use os.Mkdir when mkAll is false to preserve the documented semantics, while retaining the simplified Windows implementation for ownership and permissions. Originally introduced in [moby/moby@bfe252b78184][1], which added a Windows-specific implementation to work around limitations on that platform; > A recent change to use pkg\idtools causes a chown to be on the > startup path of the daemon. Chown is not supported on Windows, > hence the daemon would not start. [1]: moby/moby@bfe252b Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows implementation of mkdirAs was originally introduced as a minimal wrapper around os.MkdirAll because ownership is not supported on Windows and the uid/gid parameters were only needed to keep the daemon starting.
As a result, MkdirAndChown would also create missing parent directories, unlike the Unix implementation.
Use os.Mkdir when mkAll is false to preserve the documented semantics, while retaining the simplified Windows implementation for ownership and permissions.
Originally introduced in moby/moby@bfe252b78184, which added a Windows-specific implementation to work around limitations on that platform;