sessions: reduce hidden animation work#326668
Draft
justschen wants to merge 3 commits into
Draft
Conversation
- Pauses continuous session-title shimmer and pixel-spinner animations when their elements are outside the viewport or their document is hidden, avoiding rendering work that cannot be seen. - Centralizes visibility-aware CSS animation handling so animated components share window lifecycle cleanup and resume synchronization instead of maintaining separate observers. - Caps the shimmer's visual update cadence while preserving its existing three-second appearance, reducing unnecessary paint pressure in large session lists. - Documents the sessions-list animation behavior for future maintenance. (Commit message generated by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces hidden animation work in session lists by centralizing visibility-aware animation pausing.
Changes:
- Adds shared viewport/document visibility handling.
- Applies it to title shimmers and pixel spinners.
- Caps shimmer updates and documents behavior.
Show a summary per file
| File | Description |
|---|---|
src/vs/base/browser/animationSync.ts |
Adds shared animation visibility tracking. |
src/vs/base/browser/ui/pixelSpinner/pixelSpinner.ts |
Migrates spinner tracking to the shared helper. |
src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts |
Pauses hidden title shimmers. |
src/vs/sessions/contrib/sessions/browser/media/sessionsList.css |
Adds stepped cadence and paused styling. |
src/vs/sessions/SESSIONS_LIST.md |
Documents animation behavior. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Medium
Contributor
|
Base:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Commit message generated by Copilot)