Skip to content

Add setting to control terminal resize overlay#326570

Merged
anthonykim1 merged 2 commits into
mainfrom
anthonykim1/overlayTerminalSetting
Jul 21, 2026
Merged

Add setting to control terminal resize overlay#326570
anthonykim1 merged 2 commits into
mainfrom
anthonykim1/overlayTerminalSetting

Conversation

@anthonykim1

Copy link
Copy Markdown
Contributor

Resolves: #295790

  • Add terminal.integrated.resizeDimensionsOverlay.enabled to control the terminal resize dimensions overlay.
  • Keep the setting enabled by default to preserve existing behavior.
  • Create or dispose the overlay when the setting changes.
  • Apply setting changes to open terminals without requiring a reload or terminal restart.

Verification:

  • Resize a terminal with the setting enabled and confirm the dimensions overlay appears.
  • Disable the setting and confirm resizing no longer shows the overlay.
  • Re-enable the setting and confirm the overlay returns without restarting the terminal.
  • npm run typecheck-client
  • npm run valid-layers-check

Inspirations from:

@anthonykim1 anthonykim1 self-assigned this Jul 20, 2026
Copilot AI review requested due to automatic review settings July 20, 2026 05:35
@anthonykim1 anthonykim1 added this to the 1.130.0 milestone Jul 20, 2026
@anthonykim1
anthonykim1 marked this pull request as ready for review July 20, 2026 05:35
@anthonykim1
anthonykim1 enabled auto-merge (squash) July 20, 2026 05:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a configurable terminal resize-dimensions overlay with live updates for open terminals.

Changes:

  • Registers terminal.integrated.resizeDimensionsOverlay.enabled, defaulting to enabled.
  • Creates or disposes overlays when configuration changes.
  • Integrates the setting into terminal configuration.
Show a summary per file
File Description
terminalResizeDimensionsOverlayConfiguration.ts Defines the new setting schema.
terminal.resizeDimensionsOverlay.contribution.ts Applies the setting initially and on changes.
terminalContribExports.ts Registers the setting with terminal configuration.

Review details

  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Medium

@anthonykim1
anthonykim1 marked this pull request as draft July 20, 2026 05:41
auto-merge was automatically disabled July 20, 2026 05:41

Pull request was converted to draft

@anthonykim1
anthonykim1 marked this pull request as ready for review July 20, 2026 05:48
@aeschli
aeschli marked this pull request as draft July 20, 2026 05:54
@anthonykim1
anthonykim1 marked this pull request as ready for review July 21, 2026 02:22
@anthonykim1 anthonykim1 modified the milestones: 1.130.0, 1.131.0 Jul 21, 2026
@anthonykim1
anthonykim1 enabled auto-merge (squash) July 21, 2026 02:24
@anthonykim1
anthonykim1 merged commit 8c86698 into main Jul 21, 2026
29 checks passed
@anthonykim1
anthonykim1 deleted the anthonykim1/overlayTerminalSetting branch July 21, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it possible to disable dimensions visual overlay on terminal resize

3 participants