Add setting to control terminal resize overlay#326570
Merged
Merged
Conversation
anthonykim1
marked this pull request as ready for review
July 20, 2026 05:35
anthonykim1
enabled auto-merge (squash)
July 20, 2026 05:35
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configurable terminal resize-dimensions overlay with live updates for open terminals.
Changes:
- Registers
terminal.integrated.resizeDimensionsOverlay.enabled, defaulting to enabled. - Creates or disposes overlays when configuration changes.
- Integrates the setting into terminal configuration.
Show a summary per file
| File | Description |
|---|---|
terminalResizeDimensionsOverlayConfiguration.ts |
Defines the new setting schema. |
terminal.resizeDimensionsOverlay.contribution.ts |
Applies the setting initially and on changes. |
terminalContribExports.ts |
Registers the setting with terminal configuration. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Medium
anthonykim1
marked this pull request as draft
July 20, 2026 05:41
auto-merge was automatically disabled
July 20, 2026 05:41
Pull request was converted to draft
anthonykim1
marked this pull request as ready for review
July 20, 2026 05:48
aeschli
marked this pull request as draft
July 20, 2026 05:54
anthonykim1
marked this pull request as ready for review
July 21, 2026 02:22
anthonykim1
enabled auto-merge (squash)
July 21, 2026 02:24
DonJayamanne
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #295790
terminal.integrated.resizeDimensionsOverlay.enabledto control the terminal resize dimensions overlay.Verification:
npm run typecheck-clientnpm run valid-layers-checkInspirations from:
terminalCommandGuideConfiguration.TerminalCommandGuideContribution.TerminalResizeDimensionsOverlayContribution.terminalContribConfigurationaggregation point.