-
Notifications
You must be signed in to change notification settings - Fork 47
feat: Add async hook, plugin, and flag tracker #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| from typing import Any, Callable | ||
|
|
||
| from ldclient.context import Context | ||
| from ldclient.impl.aio.concurrency import AsyncCallbackScheduler, AsyncLock | ||
| from ldclient.impl.listeners import Listeners | ||
| from ldclient.interfaces import FlagChange, FlagTracker, FlagValueChange | ||
|
|
||
|
|
||
| class AsyncFlagValueChangeListener: | ||
| """Calls the user's listener when a specific flag's evaluated value changes for a specific context.""" | ||
|
|
||
| def __init__(self, key: str, context: Context, listener: Callable[[FlagValueChange], None], eval_fn: Callable, scheduler: AsyncCallbackScheduler, value: Any): | ||
| self.__key = key | ||
| self.__context = context | ||
| self.__listener = listener | ||
| self.__eval_fn = eval_fn | ||
| self.__scheduler = scheduler | ||
|
|
||
| self.__lock = AsyncLock() | ||
| self.__value = value | ||
|
|
||
| @classmethod | ||
| async def create(cls, key: str, context: Context, listener: Callable[[FlagValueChange], None], eval_fn: Callable, scheduler: AsyncCallbackScheduler) -> 'AsyncFlagValueChangeListener': | ||
| """Evaluates the flag once to capture the baseline value, then returns the listener.""" | ||
| value = await eval_fn(key, context) | ||
| return cls(key, context, listener, eval_fn, scheduler, value) | ||
|
|
||
| def __call__(self, flag_change: FlagChange): | ||
| self.__scheduler.call(self._on_flag_change, flag_change) | ||
|
|
||
| async def _on_flag_change(self, flag_change: FlagChange): | ||
| if flag_change.key != self.__key: | ||
| return | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Flag key filtered after schedulingMedium Severity
Reviewed by Cursor Bugbot for commit 564abb6. Configure here. |
||
|
|
||
| async with self.__lock: | ||
| new_value = await self.__eval_fn(self.__key, self.__context) | ||
| old_value, self.__value = self.__value, new_value | ||
|
|
||
| if new_value == old_value: | ||
| return | ||
|
|
||
| self.__listener(FlagValueChange(self.__key, old_value, new_value)) | ||
|
cursor[bot] marked this conversation as resolved.
|
||
|
|
||
|
|
||
| class AsyncFlagTrackerImpl(FlagTracker): | ||
| def __init__(self, listeners: Listeners, eval_fn: Callable): | ||
| self.__listeners = listeners | ||
| self.__eval_fn = eval_fn | ||
| self.__scheduler = AsyncCallbackScheduler() | ||
|
|
||
| def add_listener(self, listener: Callable[[FlagChange], None]): | ||
| self.__listeners.add(listener) | ||
|
|
||
| def remove_listener(self, listener: Callable[[FlagChange], None]): | ||
| self.__listeners.remove(listener) | ||
|
|
||
| async def add_flag_value_change_listener(self, key: str, context: Context, fn: Callable[[FlagValueChange], None]) -> Callable[[FlagChange], None]: | ||
| listener = await AsyncFlagValueChangeListener.create(key, context, fn, self.__eval_fn, self.__scheduler) | ||
| self.add_listener(listener) | ||
|
|
||
| return listener | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Async tracker breaks FlagTracker contractMedium Severity
Reviewed by Cursor Bugbot for commit 564abb6. Configure here. |
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of having 2 ways to create this (init and create) when the behavior would be different.
I can see why we are doing this though. Maybe we can just add some documentation to the init making it very clear you shouldn't use this method to instantiate the change listener?