Skip to content

feat(cluster): install act for local GitHub Actions workflow runs - #3968

Open
lkingland wants to merge 1 commit into
knative:mainfrom
lkingland:coder.functions.2/62
Open

feat(cluster): install act for local GitHub Actions workflow runs#3968
lkingland wants to merge 1 commit into
knative:mainfrom
lkingland:coder.functions.2/62

Conversation

@lkingland

Copy link
Copy Markdown
Member

Changes

  • 🎁 Install pinned act (nektos/act v0.2.88) via func cluster create into $XDG_CONFIG_HOME/func/bin, alongside kubectl and kind — so func config ci workflows can be exercised locally.
  • 🎁 Generic .tar.gz install path in pkg/cluster/binaries.go (ArchiveEntry): verify the archive SHA-256, then extract a regular-file entry atomically (size/type guards).
  • 🧹 ActOverride / act() accessor (BinDir then PATH), matching kubectl/kind.
  • 🧹 e2e config-ci prefers managed BinDir/act over bare PATH (install alone does not put act on PATH).
  • 🧹 Unit tests for extractFromTarGz; comment that cache hits are existence-only (archive pin ≠ extracted binary).

Checksums match the official v0.2.88 checksums.txt for linux/darwin amd64+arm64.

/kind enhancement

Release Note

func cluster create now installs act for local GitHub Actions workflow runs

Docs

  • Docs PR required (link below)
  • Docs not required

Functions#62

@knative-prow knative-prow Bot added the kind/enhancement Feature additions or improvements to existing label Jul 25, 2026
@knative-prow

knative-prow Bot commented Jul 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Jul 25, 2026
@knative-prow
knative-prow Bot requested review from dsimansk and jrangelramos July 25, 2026 15:18
@knative-prow knative-prow Bot added the size/L 🤖 PR changes 100-499 lines, ignoring generated files. label Jul 25, 2026
@lkingland
lkingland force-pushed the coder.functions.2/62 branch 2 times, most recently from 203a650 to c613f6e Compare July 28, 2026 00:13
Adds act (nektos/act v0.2.88) via func cluster create into
$XDG_CONFIG_HOME/func/bin, with tar.gz extract support (ArchiveEntry).

Windows: close archive handles before renaming over the download path
(os.Rename Access is denied while the source is still open).

e2e config-ci prefers managed BinDir/act over bare PATH.

Functions#62
@lkingland
lkingland force-pushed the coder.functions.2/62 branch from c613f6e to 0a3dbbc Compare July 28, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. kind/enhancement Feature additions or improvements to existing size/L 🤖 PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant