test: skip gpg signing in test gitInit - #3967
Open
lkingland wants to merge 1 commit into
Open
Conversation
Global git config commit.gpgsign=true was leaking into the test's temp repository, causing 'git commit' to fail with 'No secret key' when the host has signing enabled but no matching key for the test identity. Override both commit.gpgsign and tag.gpgsign locally so the test is robust to host gitconfig. Functions#61 (recovered from local rywnuxxx)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
approved
lkingland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit.gpgsignandtag.gpgsignin the config-ci e2e helper's temp git repo so a host global GPG signing config cannot failgit commitwithNo secret keyfor the synthetic test identity./kind bug
Functions#61