feature(mutation): add support for list mutations using cel - #185
Conversation
|
Hi @olzemal. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Alexander Olzem <alexander.olzem@opendefense.cloud>
d61cfba to
85451fe
Compare
|
LGTM label has been added. DetailsGit tree hash: 0666f718ef82d3b1e89b56eec2f18e9e65c973d8 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Currently mutating a list using cel results in errors, as described in #184.
The computed CEL result for lists renders incorrectly to
Adapter: {}. Converting the CEL result to a valid go representation before passing it tosjson.Setfixes this behaviour and renders a list as valid json/yaml.I added two brief test-cases to validate the new conversion. Please let me know if we should cover more.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #184
Release Notes