Skip to content

feature(mutation): add support for list mutations using cel - #185

Merged
kcp-ci-bot merged 1 commit into
kcp-dev:mainfrom
olzemal:feature/cel-list-mutations
Aug 27, 2026
Merged

feature(mutation): add support for list mutations using cel#185
kcp-ci-bot merged 1 commit into
kcp-dev:mainfrom
olzemal:feature/cel-list-mutations

Conversation

@olzemal

@olzemal olzemal commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Currently mutating a list using cel results in errors, as described in #184.

The computed CEL result for lists renders incorrectly to Adapter: {}. Converting the CEL result to a valid go representation before passing it to sjson.Set fixes this behaviour and renders a list as valid json/yaml.

I added two brief test-cases to validate the new conversion. Please let me know if we should cover more.

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #184

Release Notes

added support for list mutations using cel

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: no Indicates the PR's author has not signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 26, 2026
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

Hi @olzemal. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2026
Signed-off-by: Alexander Olzem <alexander.olzem@opendefense.cloud>
@olzemal
olzemal force-pushed the feature/cel-list-mutations branch from d61cfba to 85451fe Compare August 26, 2026 09:00
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Aug 26, 2026

@xrstf xrstf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2026
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 0666f718ef82d3b1e89b56eec2f18e9e65c973d8

@kcp-ci-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2026
@kcp-ci-bot
kcp-ci-bot merged commit 497229f into kcp-dev:main Aug 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: support CEL mutation paths targeting individual elements of arrays

3 participants