fix(datetime): fix overlap in datetime-button modal from datetime being too short#31274
Open
droc101 wants to merge 1 commit into
Open
fix(datetime): fix overlap in datetime-button modal from datetime being too short#31274droc101 wants to merge 1 commit into
droc101 wants to merge 1 commit into
Conversation
changes min-height of ion-datetime in ion-datetime-button-overlay to 350px from 320px to prevent overlap in months spanning across six weeks in ios mode closes ionic-team#29589
|
@droc101 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29589
What is the current behavior?
The
ion-datetime.datetime-gridinside a.ion-datetime-button-overlayis set to be 320px tall instead of the normal 350px. This causes the selection circles in iOS mode to overlap other dates on months that span across six weeks (such as June 2024)What is the new behavior?
ion-datetime.datetime-gridinside.ion-datetime-button-overlayis now 350px tallDoes this introduce a breaking change?