feat: unify fields[] type naming via [JsonApiResource] (opt-in) - #209
Merged
Erlend Ellefsen (erlendellefsen) merged 2 commits intoAug 25, 2026
Merged
Conversation
Included resources' "type" (and relationship linkage pointing at them)
used the camelCased CLR class name, while the primary resource used the
controller-supplied string, so fields[type] could not target both with
one name for types like [JsonApiResource("people")] on class Author.
New opt-in flag JsonApiOptions.UseResourceAttributeTypeNames makes
included resources use their [JsonApiResource] type name when present,
falling back to the camelCased class name otherwise. Wire-affecting,
so off by default.
Erlend Ellefsen (erlendellefsen)
deleted the
feat/unify-fields-type-naming
branch
August 25, 2026 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type(and relationship linkage pointing at them) used the camelCased CLR class name, while the primary resource used the controller-supplied string.fields[type]could not target both with one name for a type like[JsonApiResource("people")]on classAuthor.JsonApiOptions.UseResourceAttributeTypeNames: when true, an included resource's type comes from its[JsonApiResource]attribute if present, falling back to the camelCased class name otherwise.StrictQueryValidation/PreserveQueryInPaginationLinks.Test plan
just check test test-contract: 677 .NET tests, TypeGen tests, and the full Deno contract suite all pass.just typegen --check: no drift.InclusionMapperTestscover the flag on, off, and falling back for a type without the attribute.