Skip to content

chore!: rm unused argument in layout_with_mds() - #2869

Open
maelle wants to merge 1 commit into
mainfrom
nooptions
Open

chore!: rm unused argument in layout_with_mds()#2869
maelle wants to merge 1 commit into
mainfrom
nooptions

Conversation

@maelle

@maelle maelle commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Fix #2730

@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if b9c764b is merged into main:

  • ✔️as_adjacency_matrix: 810ms -> 819ms [-0.89%, +2.96%]
  • ✔️as_biadjacency_matrix: 807ms -> 803ms [-2.7%, +1.61%]
  • ✔️as_data_frame_both: 1.77ms -> 1.75ms [-4.51%, +2.39%]
  • ✔️as_long_data_frame: 4.44ms -> 4.4ms [-4.26%, +2.55%]
  • ✔️es_attr_filter: 2.76ms -> 2.8ms [-1.13%, +4.17%]
  • ✔️graph_from_adjacency_matrix: 133ms -> 135ms [-2.33%, +5.66%]
  • ✔️graph_from_data_frame: 4.04ms -> 3.99ms [-3.92%, +1.68%]
  • 🚀vs_attr_filter: 1.58ms -> 1.56ms [-3.26%, -0.14%]
  • ✔️vs_by_name: 1.09ms -> 1.06ms [-7.19%, +2.11%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

layout_with_mds() unused options argument

1 participant