fix(http1): recognize \n\r\n as a head terminator in the partial-read fast path - #4147
Open
nam2ee wants to merge 1 commit into
Open
fix(http1): recognize \n\r\n as a head terminator in the partial-read fast path#4147nam2ee wants to merge 1 commit into
nam2ee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4145.
is_complete_fastrecognizes\r\n\r\nand\n\nas head terminators but not\n\r\n, while the full parser (httparse) accepts all three. So a request whose head ends with\n\r\nparses fine when it arrives in a single read, but stalls when it arrives split across reads: the fast path never reports the head complete and the connection keeps waiting for more bytes.This extends the
\nbranch to also accept a following\r\n, using the same panic-safe slicing idiom as the\rbranch. Added the\n\r\nwitness and the\n\rnegative totest_is_complete_fast, plus a parse-level test documenting that the full parser accepts this terminator.