Skip to content

feat(tables): add partition_by and sorted_by configuration - #105

Merged
hotdata-automation[bot] merged 1 commit into
mainfrom
openapi-update-30805380727
Aug 3, 2026
Merged

feat(tables): add partition_by and sorted_by configuration#105
hotdata-automation[bot] merged 1 commit into
mainfrom
openapi-update-30805380727

Conversation

@hotdata-automation

Copy link
Copy Markdown
Contributor

Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www.hotdata.dev/pull/292

@hotdata-automation
hotdata-automation Bot requested a review from a team as a code owner August 3, 2026 10:24
@hotdata-automation
hotdata-automation Bot requested review from shefeek-jinnah and removed request for a team August 3, 2026 10:24
@hotdata-automation
hotdata-automation Bot enabled auto-merge (squash) August 3, 2026 10:24
Comment thread CHANGELOG.md

### Changed

- feat(tables): add partition_by and sorted_by configuration

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: this bullet is the raw commit subject, not the SDK-facing description the rest of the file uses (not blocking). Compare the precedent for the very similar key addition (CHANGELOG.md:82): "AddManagedTableDecl, AddManagedTableRequest, and DatabaseDefaultTableDecl gain an optional key field…". Consumers reading the release notes here don't learn that two new public types (TablePartitionKey, TableSortKey) were added or which models gained fields. Suggest rewording before release, e.g.:

Suggested change
- feat(tables): add partition_by and sorted_by configuration
- `AddManagedTableDecl`, `AddManagedTableRequest`, and `DatabaseDefaultTableDecl`
gain optional `partition_by` and `sorted_by` fields describing a managed
table's storage layout, along with the new `TablePartitionKey` and
`TableSortKey` models. Both are declared at table-create time and fixed
thereafter; omitting them preserves today's behaviour.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated output is internally consistent: new models registered in src/models/mod.rs and .openapi-generator/FILES in the right sort positions, serde attributes match the existing generated conventions (double_option for nullable optionals is already used in 45 other models), docs emitted, and the three new() constructors keep their existing required-arg signatures so no caller breaks. src/resources.rs passes request bodies through, so no hand-written plumbing is needed. One non-blocking changelog wording note inline.

@hotdata-automation
hotdata-automation Bot merged commit ab70d39 into main Aug 3, 2026
4 checks passed
@hotdata-automation
hotdata-automation Bot deleted the openapi-update-30805380727 branch August 3, 2026 10:26
@shefeek-jinnah

Copy link
Copy Markdown

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant