feat(tables): add partition_by and sorted_by configuration - #105
Conversation
|
|
||
| ### Changed | ||
|
|
||
| - feat(tables): add partition_by and sorted_by configuration |
There was a problem hiding this comment.
super nit: this bullet is the raw commit subject, not the SDK-facing description the rest of the file uses (not blocking). Compare the precedent for the very similar key addition (CHANGELOG.md:82): "AddManagedTableDecl, AddManagedTableRequest, and DatabaseDefaultTableDecl gain an optional key field…". Consumers reading the release notes here don't learn that two new public types (TablePartitionKey, TableSortKey) were added or which models gained fields. Suggest rewording before release, e.g.:
| - feat(tables): add partition_by and sorted_by configuration | |
| - `AddManagedTableDecl`, `AddManagedTableRequest`, and `DatabaseDefaultTableDecl` | |
| gain optional `partition_by` and `sorted_by` fields describing a managed | |
| table's storage layout, along with the new `TablePartitionKey` and | |
| `TableSortKey` models. Both are declared at table-create time and fixed | |
| thereafter; omitting them preserves today's behaviour. |
There was a problem hiding this comment.
Generated output is internally consistent: new models registered in src/models/mod.rs and .openapi-generator/FILES in the right sort positions, serde attributes match the existing generated conventions (double_option for nullable optionals is already used in 45 other models), docs emitted, and the three new() constructors keep their existing required-arg signatures so no caller breaks. src/resources.rs passes request bodies through, so no hand-written plumbing is needed. One non-blocking changelog wording note inline.
|
approved |
Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www.hotdata.dev/pull/292