feat(gax): add ResumableUploadStatus and ResumableUploadProgressListener - #14073
feat(gax): add ResumableUploadStatus and ResumableUploadProgressListener#14073whowes wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new resumable upload progress tracking API, including the ResumableUploadProgressListener interface, the ResumableUploadStatus AutoValue class, and comprehensive unit tests. The feedback suggests adding a package-private constructor to ResumableUploadStatus to prevent external subclassing and preserve immutability.
| @BetaApi | ||
| @NullMarked | ||
| @AutoValue | ||
| public abstract class ResumableUploadStatus { |
There was a problem hiding this comment.
To prevent users from subclassing this AutoValue class outside of the package (which could bypass the immutability guarantees), it is a best practice to define a package-private constructor.
| public abstract class ResumableUploadStatus { | |
| public abstract class ResumableUploadStatus { | |
| ResumableUploadStatus() {} |
|
|
1 participant
These classes will provide library users a mechanism to track resumable upload progress.