Skip to content

ci: update rotate-keys for additional key#16269

Open
scotthart wants to merge 6 commits into
googleapis:mainfrom
scotthart:ci_update_key_rotation
Open

ci: update rotate-keys for additional key#16269
scotthart wants to merge 6 commits into
googleapis:mainfrom
scotthart:ci_update_key_rotation

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@scotthart
scotthart requested a review from a team as a code owner July 20, 2026 21:25

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the key rotation script rotate-keys.sh to support multiple service accounts, specifically adding the observability service account. The feedback recommends assigning command substitution outputs to variables to prevent swallowing errors under set -e, and refactoring the space-separated file types into a Bash array to avoid unquoted variable expansion issues.

Comment thread ci/cloudbuild/builds/rotate-keys.sh Outdated
Comment thread ci/cloudbuild/builds/rotate-keys.sh Outdated
Comment thread ci/cloudbuild/builds/rotate-keys.sh Outdated
Comment thread ci/cloudbuild/builds/rotate-keys.sh Outdated
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (fd956fb) to head (db50235).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16269      +/-   ##
==========================================
- Coverage   92.27%   92.27%   -0.01%     
==========================================
  Files        2218     2218              
  Lines      206654   206654              
==========================================
- Hits       190699   190687      -12     
- Misses      15955    15967      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
scotthart and others added 2 commits July 21, 2026 10:27
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant