Validate function call author before resuming auth-gated tool calls#6474
Open
prasanna8585 wants to merge 1 commit into
Open
Validate function call author before resuming auth-gated tool calls#6474prasanna8585 wants to merge 1 commit into
prasanna8585 wants to merge 1 commit into
Conversation
_AuthLlmRequestProcessor.run_async resumed and executed a tool call found by ID in session history without checking that the call was authored by the current agent. request_confirmation.py's equivalent resume path already validates this (original_fc_event.author != agent.name), but auth_preprocessor.py did not. In a shared session, this could cause one agent to resume and execute a different agent's auth-gated tool call using its own canonical_tools, rather than the originating agent's.
adk-bot
added
the
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_AuthLlmRequestProcessor.run_async resumes and executes a tool call found by ID in session history, but did not check that the call was authored by the current agent before doing so.
request_confirmation.py's equivalent resume path already validates this (original_fc_event.author != agent.name). This applies the same check here, consistent with that existing pattern.