Side-effect of changing username on codeowners is declared#23842
Side-effect of changing username on codeowners is declared#23842OlayinkaAtobiloye wants to merge 6 commits into
Conversation
|
Hi @cmwilson21, solved an issue from the project board, and raised this PR, could you take a look when chanced please? Thankls! |
|
👋 @OlayinkaAtobiloye Awesome! I'll get this triaged! ⚡ |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
rachaelrenk
left a comment
There was a problem hiding this comment.
Great work adding this new section ✨ I made a few suggested edits for style and voice, and left one comment with a question for your consideration. Thanks! 🚀
|
|
||
| ## CODEOWNERS files | ||
|
|
||
| After changing your username, CODEOWNERS files will need to be manually updated. When viewing the CODEOWNERS files from the web, a warning will show if the file contains any unknown user(s) or user(s) without write access. We recommend updating all relevant CODEOWNERS files with your new username. |
There was a problem hiding this comment.
| After changing your username, CODEOWNERS files will need to be manually updated. When viewing the CODEOWNERS files from the web, a warning will show if the file contains any unknown user(s) or user(s) without write access. We recommend updating all relevant CODEOWNERS files with your new username. | |
| After changing your username, CODEOWNERS files need to be manually updated. When viewing the CODEOWNERS files on the web, a warning displays if the file contains any unknown user(s) or user(s) without write access. We recommend updating all relevant CODEOWNERS files with your new username. |
There was a problem hiding this comment.
What does the web mean in this context, or where would a user view the CODEOWNERS file(s) online? If possible, be more specific. For example, if the web actually means GitHub.com, then let's say that.
There was a problem hiding this comment.
Hi @rachaelrenk, thanks for the review! The changes suggested were addressed in this PR - which was created for another issue but happened to have the changes made here - and has now been merged in. So I will close this PR. Thank you!
Why:
Closes #17099
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: