Skip to content

Side-effect of changing username on codeowners is declared#23842

Closed
OlayinkaAtobiloye wants to merge 6 commits into
github:mainfrom
OlayinkaAtobiloye:main
Closed

Side-effect of changing username on codeowners is declared#23842
OlayinkaAtobiloye wants to merge 6 commits into
github:mainfrom
OlayinkaAtobiloye:main

Conversation

@OlayinkaAtobiloye

@OlayinkaAtobiloye OlayinkaAtobiloye commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

Why:

Closes #17099

What's being changed (if available, include any code snippets, screenshots, or gifs):

Image of the GitHub Docs "Changing Your Username" page with recent content change reflected.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Feb 10, 2023
@OlayinkaAtobiloye

Copy link
Copy Markdown
Contributor Author

Hi @cmwilson21, solved an issue from the project board, and raised this PR, could you take a look when chanced please? Thankls!

@cmwilson21

Copy link
Copy Markdown
Contributor

👋 @OlayinkaAtobiloye Awesome! I'll get this triaged! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team code owners Content related to code owners account-and-profile Content relating to account and profile waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 10, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-personal-account-settings/changing-your-github-username.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@rachaelrenk rachaelrenk self-requested a review February 13, 2023 19:37

@rachaelrenk rachaelrenk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work adding this new section ✨ I made a few suggested edits for style and voice, and left one comment with a question for your consideration. Thanks! 🚀


## CODEOWNERS files

After changing your username, CODEOWNERS files will need to be manually updated. When viewing the CODEOWNERS files from the web, a warning will show if the file contains any unknown user(s) or user(s) without write access. We recommend updating all relevant CODEOWNERS files with your new username.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After changing your username, CODEOWNERS files will need to be manually updated. When viewing the CODEOWNERS files from the web, a warning will show if the file contains any unknown user(s) or user(s) without write access. We recommend updating all relevant CODEOWNERS files with your new username.
After changing your username, CODEOWNERS files need to be manually updated. When viewing the CODEOWNERS files on the web, a warning displays if the file contains any unknown user(s) or user(s) without write access. We recommend updating all relevant CODEOWNERS files with your new username.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the web mean in this context, or where would a user view the CODEOWNERS file(s) online? If possible, be more specific. For example, if the web actually means GitHub.com, then let's say that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rachaelrenk, thanks for the review! The changes suggested were addressed in this PR - which was created for another issue but happened to have the changes made here - and has now been merged in. So I will close this PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

account-and-profile Content relating to account and profile code owners Content related to code owners content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Side-effect of changing username on codeowners is not declared

3 participants