Skip to content

Workflow job execution doc edited to clarify that 'env' context is not available in job 'if' conditional #23859

Merged
hubwriter merged 10 commits into
github:mainfrom
OlayinkaAtobiloye:olayinka/workflows
Feb 14, 2023
Merged

Workflow job execution doc edited to clarify that 'env' context is not available in job 'if' conditional #23859
hubwriter merged 10 commits into
github:mainfrom
OlayinkaAtobiloye:olayinka/workflows

Conversation

@OlayinkaAtobiloye

@OlayinkaAtobiloye OlayinkaAtobiloye commented Feb 12, 2023

Copy link
Copy Markdown
Contributor

Why:

Closes #21927, #17099

What's being changed (if available, include any code snippets, screenshots, or gifs):

Screenshot of app with current change.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Feb 12, 2023
@OlayinkaAtobiloye

Copy link
Copy Markdown
Contributor Author

Hi, @cmwilson21! I raised a PR addressing a workflow job execution, could you please check it out when chanced? Thanks!

@github-actions

github-actions Bot commented Feb 12, 2023

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-personal-account-settings/changing-your-github-username.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
actions/using-jobs/using-conditions-to-control-job-execution.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21

Copy link
Copy Markdown
Contributor

@OlayinkaAtobiloye great work! I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 13, 2023
@Esiakha

This comment was marked as spam.

@Esiakha

This comment was marked as spam.

@OlayinkaAtobiloye

Copy link
Copy Markdown
Contributor Author

self-review checklist.

Hi @Esiakha, it is now completed!

hubwriter
hubwriter previously approved these changes Feb 14, 2023

@hubwriter hubwriter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlayinkaAtobiloye - Many thanks for making these documentation changes - much appreciated. 🙇

I've made a few small changes, just to keep things in line with our style guide.

I'll get this merged/published.

Thanks again for contributing to the docs.
🚀

Comment thread content/actions/using-jobs/using-conditions-to-control-job-execution.md Outdated
@hubwriter hubwriter enabled auto-merge (squash) February 14, 2023 08:17
@hubwriter hubwriter merged commit 95df39b into github:main Feb 14, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@OlayinkaAtobiloye OlayinkaAtobiloye deleted the olayinka/workflows branch March 25, 2023 13:57
@avalosriveraamericacitlali-cell

Copy link
Copy Markdown

Por qué:

Cierra los números #41927 y #170.

¿Qué se va a cambiar? (Si es posible, incluya fragmentos de código, capturas de pantalla o GIF):

Captura de pantalla de la aplicación con el cambio actual.

Marque las siguientes casillas:

  • He revisado mis cambios en el entorno de pruebas (busca el comentario "Comentario generado automáticamente" y haz clic en los enlaces de la columna "Vista previa" para ver tus últimos cambios).
  • Para los cambios de contenido, he completado la lista de verificación de autoevaluación .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow job execution doc should clarify that 'env' context is not available in job 'if' conditional

5 participants