Rust: Add a couple of new metrics to rust/summary/summary-statistics. - #22328
Rust: Add a couple of new metrics to rust/summary/summary-statistics.#22328geoffw0 wants to merge 3 commits into
Conversation
geoffw0
added
no-change-note-required
There was a problem hiding this comment.
Pull request overview
Adds broader extraction and taint-graph metrics to Rust summary statistics.
Changes:
- Distinguishes user files from all extracted files.
- Reports highly colocated data-flow nodes.
- Updates reduced-summary expectations for the renamed metric.
Show a summary per file
| File | Description |
|---|---|
rust/ql/src/queries/summary/Stats.qll |
Defines the new metrics. |
rust/ql/src/queries/summary/SummaryStats.ql |
Includes additional extraction statistics. |
rust/ql/test/query-tests/diagnostics/SummaryStatsReduced.expected |
Updates the expected metric name. |
rust/ql/integration-tests/hello-workspace/summary.rust-project.expected |
Updates rust-project expectations. |
rust/ql/integration-tests/hello-workspace/summary.cargo.expected |
Updates Cargo expectations. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
| * Holds if there are at least 10 data flow nodes in the same location | ||
| * as `n`. | ||
| */ | ||
| private predicate isColocated10(DataFlow::Node n) { |
There was a problem hiding this comment.
I'm not convinced that this metric will be super useful.
There was a problem hiding this comment.
Yeah, I'm not sure either. I'm trying to solve the problem of large changes to the shape of the data flow graph being difficult to detect and characterise. I tried a few things, this was the most promising, but it's not great.
|
The DCA run looks fine. I'll wait until we figure out what's going on with the data flow issue we're investigating before I either justify, improve, or remove the "highly colocated nodes" metric. |
Add a couple of new metrics to
rust/summary/summary-statistics:(I'm going to do a small DCA run because there's some integration between this query and the reports there, to be sure I haven't broken anything)