test(server-utils): Remove ioredis unit test that replicated SDK async-context logic#22099
Merged
Merged
Conversation
…c-context logic The suite stubbed the SDK's async context strategy via `setAsyncContextStrategy` to drive spans, duplicating SDK internals in the test layer. The ioredis node integration suite already covers the orchestrion path end to end. Co-Authored-By: Opus 4.8 <noreply@anthropic.com>
andreiborza
requested review from
JPeer264,
chargome,
isaacs,
logaretm and
mydea
and removed request for
a team
logaretm
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the ioredis unit test that stubbed the SDK's async context strategy to drive spans, which replicated SDK internals in the test layer. Per the review thread in #21885, we rely on the integration tests instead.
The orchestrion path is covered by the
redis(ioredis scenario) andredis-cachenode integration suites. TheresponseHookand connect-span cases aren't cleanly testable on the orchestrion path (the hook is wired internally for caching) and these suites are Docker-gated, so they're left as a possible follow-up rather than migrated now.Ref: #21885 (comment)