test(node): Attempt to unflake docker-based node integration tests#21905
Merged
Lms24 merged 2 commits intoJul 7, 2026
Conversation
Lms24
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JPeer264
approved these changes
Jul 2, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. Let's hope for the best.
Lms24
force-pushed
the
lms/test-unflake-node-docker-compose-integration-tests
branch
from
3a5fe8e to
5ce16b2
Compare
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had a few knex and mysql integration test timeouts recently. Clanker thinks this is attributed to us not determinisitcally stopping the correct docker containers in tests running simultaneously that start/stop containers. No guarantee that this works but probably worth a shot.