docs(agents): Make create-java-pr defer to pr.mdc for conventions - #5931
Closed
runningcode wants to merge 1 commit into
Closed
docs(agents): Make create-java-pr defer to pr.mdc for conventions#5931runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
The skill declared pr.mdc the source of truth and then restated most of it anyway: branch naming, commit conventions, the full PR template, the changelog subsection table, entry format, and the stack list warnings all existed in both files. Two copies of the same conventions drift apart. Keep the procedure in the skill (ordered steps and the branch-type detection heuristic, which pr.mdc does not cover) and point at pr.mdc for each convention. Also drop the inlined PR template from pr.mdc in favor of .github/pull_request_template.md, so the template lives in one place, and correct the commit subject limit from 100 to 70 characters to match Sentry's commit message conventions.
📲 Install BuildsAndroid
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Trims the overlap between the
create-java-prskill and.cursor/rules/pr.mdc.The skill already declared
pr.mdc"the source of truth," then restated most of it anyway — branch naming, commit message conventions, the full PR body template, the changelog subsection table, the entry format, and the stack list warnings all lived in both files.create-java-pr/SKILL.md— keeps the parts that are genuinely its own: the ordered procedure and the Step 0 branch-type detection heuristic, whichpr.mdcdoesn't cover. Every convention now links to the owningpr.mdcsection instead of restating it.pr.mdc— the inlined PR body template is replaced by a pointer to.github/pull_request_template.md, so the template exists in one place rather than three.pr.mdc— commit subject limit corrected from 100 to 70 characters, matching Sentry's commit message conventions.Net −123/+49 lines.
💡 Motivation and Context
Duplicated conventions drift. The PR template in particular existed in three copies (
.github/pull_request_template.md,pr.mdc, and the skill), so a change to the real template would silently leave two stale copies that agents keep using.💚 How did you test it?
Docs only, no code changes. Verified that all six
pr.mdcsections the skill now references resolve to real headings in that file.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Independent of #5930, which removes
coding.mdc/overview_dev.mdc. No file overlap between the two.#skip-changelog