[material_ui, cupertino_ui] Migrate macros that contain @tool - #12271
Merged
Conversation
github-actions
Bot
added
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces several {@macro ...} documentation directives with explicit doc comments and temporary TODO notes across multiple UI components in the cupertino_ui and material_ui packages. A review comment identifies a copy-paste error in packages/material_ui/lib/src/autocomplete.dart where the documentation for textEditingController incorrectly references [RawAutocomplete.focusNode] instead of [RawAutocomplete.textEditingController].
11 tasks
Piinks
reviewed
Jul 22, 2026
dkwingsmt
added
the
autosubmit
8 tasks
Contributor
|
autosubmit label was removed for flutter/packages/12271, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
Contributor
navaronbracke
pushed a commit
to navaronbracke/flutter
that referenced
this pull request
Jul 29, 2026
…er#190216) flutter/packages@3e63635...dd11626 2026-07-29 stuartmorgan@google.com [pigeon] Clean up legacy registrant code (flutter/packages#12205) 2026-07-29 me@davidmiguel.com [go_router] Add BlockedInitialNavigationException for blocked initial deep links (flutter/packages#12213) 2026-07-28 stuartmorgan@google.com [file_selector] Switch to Swift Testing (flutter/packages#12235) 2026-07-28 269567208+reidbaker-agent@users.noreply.github.com Exempt evals directories from version checks (flutter/packages#12299) 2026-07-28 dkwingsmt@users.noreply.github.com [material_ui, cupertino_ui] Migrate macros that contain `@tool` (flutter/packages#12271) 2026-07-28 katelovett@google.com [material_ui, cupertino_ui] Fix API doc references (flutter/packages#12274) 2026-07-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Delete `GeneratedCameraxLibrary.java` (flutter/packages#12294) 2026-07-28 engine-flutter-autoroll@skia.org Roll Flutter from 9988960 to 0f02463 (16 revisions) (flutter/packages#12300) 2026-07-28 developeryusuf@icloud.com [vector_graphics_compiler] Ignore unrecognized font-weight values (flutter/packages#12199) 2026-07-28 stuartmorgan@google.com [tool] Support promoting to 1.0 in batch releases (flutter/packages#12262) 2026-07-28 1063596+reidbaker@users.noreply.github.com ci: Fix Zizmor github-env failure in install_flutter action (flutter/packages#12298) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See flutter/flutter#189629.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2