docs: pipeline: outputs: elasticsearch: opensearch: document YAML quoting for strftime values#2625
Merged
Conversation
…ting for strftime values - Add note that strftime format values beginning with % (logstash_dateformat, time_key_format) must be quoted in YAML, since % is a reserved character and an unquoted value like `logstash_dateformat: %Y.%m.%d` fails to parse - Fix MD060 table alignment in the write_operation tables - Fix MD060 header spacing in the OpenSearch parameters table Fixes fluent#2624 Signed-off-by: Eric D. Schabell <eric@schabell.org>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughElasticsearch and OpenSearch documentation now explain YAML quoting for strftime formats beginning with ChangesOutput documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
@patrick-stephens ready for review! |
patrick-stephens
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logstash_dateformat: %Y.%m.%dfails to parseFixes #2624
Summary by CodeRabbit
strftimevalues beginning with%to prevent parsing errors.