variant_utils: tighten MessagePack nesting limit#94
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
marked this pull request as ready for review
July 21, 2026 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
the exact boundary
beyond it
Why
CTraces already bounded recursive MessagePack attribute decoding, but the
64-level limit remains high for downstream consumers such as Fluent Bit that
decode traces on relatively small coroutine stacks. Aligning the limit at 32
reduces stack usage and matches the corresponding CMetrics mitigation.
Validation
scripts/agent-test.sh -R '^ctr-test-decoding$'scripts/agent-verify.sh(4/4 tests passed)valgrind --quiet --error-exitcode=99 --leak-check=full --show-leak-kinds=definite,indirect ../build/agent/tests/ctr-test-decodingThe serialized format and helper entry points are unchanged. Values nested
beyond the tightened safety limit are now rejected.