Add integration tests for packages/fresh/src/mod.ts (#863, #864, #865) by rewrite0w0 · Pull Request #988 · fedify-dev/fedify

rewrite0w0 · 2026-08-08T07:24:25Z

Closes #863, Closes #864, Closes #865

Background

@fedify/fresh provides middleware integration between Fedify and Fresh. To protect the baseline coexistence of standard Fresh pages and Fedify federation endpoints, dedicated regression tests were added for core integration behaviors:

Not Found Delegation (Test not-found delegation in @fedify/fresh #863): Ensures unhandled routes fall back to Fresh's ctx.next().
Not Acceptable Fallback (Test not-acceptable fallback in @fedify/fresh #864): Ensures browser HTML requests render via Fresh first, returning 406 only when Fresh returns 404.
Context Data Flow (Test context data flow in @fedify/fresh #865): Ensures application state in Fresh context flows into federation.fetch() via createContextData.

Changes

Add unit tests in packages/fresh/src/mod.test.ts:
- integrateFetchOptions(): Verify onNotFound delegates to ctx.next().
- integrateFetchOptions(): Verify onNotAcceptable returns Fresh response for non-404 results and returns 406 when Fresh returns 404.
- integrateHandler(): Verify createContextData is called with Fresh context and the result is forwarded to federation.fetch().

Testing

mise run check-each fresh
deno test --allow-all src/mod.test.ts (5 passed, 0 failed)

AI assistance

This PR description and test implementations were drafted with AI assistance (Gemini) and finalized after human review and testing.

Assisted-by: Gemini:3.0

…fy-dev#864) Assisted-by: Gemini:3.0

…dev#865) Assisted-by: Gemini:3.0

netlify · 2026-08-08T07:24:30Z

✅ Deploy Preview for fedify-json-schema canceled.

Name	Link
🔨 Latest commit	`1232bc7`
🔍 Latest deploy log	https://app.netlify.com/projects/fedify-json-schema/deploys/6a778acc017d0800087f0130

coderabbitai · 2026-08-08T07:27:00Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

The Fresh adapter now includes integration tests for response handling and context-data propagation. The package adds a Deno test task for src/mod.test.ts.

Changes

Fresh integration helper tests

Layer / File(s)	Summary
Fetch option response handling `packages/fresh/src/mod.test.ts`	Adds a reusable Fresh context and tests `onNotFound` delegation plus `onNotAcceptable` handling for non-404 and 404 responses.
Handler context data flow `packages/fresh/src/mod.test.ts`, `packages/fresh/deno.json`	Tests synchronous and asynchronous context-data factories, request forwarding, and response propagation through `federation.fetch()`. Adds a Deno task for the test file.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Test not-found delegation in @fedify/express #857 — Adds integration tests for federation request handling, including delegation of unhandled or 404 requests to the host framework.

Possibly related PRs

fedify-dev/fedify#985 — Adds integration tests and a package test task for async context-data propagation in the Express adapter.

Suggested reviewers: dahlia

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the added integration tests and the affected Fresh module.
Description check	✅ Passed	The description directly explains the regression tests, linked issues, affected behaviors, and validation results.
Linked Issues check	✅ Passed	The tests cover all objectives from issues `#863`, `#864`, and `#865`, including delegation, fallback responses, and context data flow.
Out of Scope Changes check	✅ Passed	The changes are limited to Fresh integration tests and a related Deno test task; no unrelated code changes are identified.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/fresh/src/mod.test.ts`:
- Around line 19-22: Update the ctx.next mock in the test to a regular method
that asserts its receiver is ctx, rather than an arrow function that ignores
this. Keep the existing nextCalled tracking and Response result, so the test
verifies onNotFound invokes ctx.next with the correct bound receiver.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: db4cc5d4-d8ca-4bd9-a2c2-f07083d4696e

📥 Commits

Reviewing files that changed from the base of the PR and between 15ad151 and dc5b53e.

📒 Files selected for processing (1)

packages/fresh/src/mod.test.ts

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/fresh/src/mod.test.ts`:
- Around line 38-39: Update the assertions in the test around the forwarded
request and returned response to use strict identity checks: replace value
equality for passedRequest/request and response status validation with
assertStrictEquals(passedRequest, request) and assertStrictEquals(response,
notFoundResponse), preserving the delegation expectations.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 34835d92-f2f0-4e19-88c0-1659fe75f446

📥 Commits

Reviewing files that changed from the base of the PR and between dc5b53e and 13668e4.

📒 Files selected for processing (1)

packages/fresh/src/mod.test.ts

…test

2chanhaeng

The test task is missing, and some comments are written in Korean. As stated in CONTRIBUTING.md, this repository requires human checking for contributions. Please check the changes carefully before submitting a PR. And especially, if the PR is about tests, please test on your local machine before submitting a PR.

2chanhaeng · 2026-08-08T17:35:03Z

+  const handler = integrateHandler(mockFederation, createContextData);
+  const response = await handler(ctx);
+
+  assertEquals(receivedContextData, expectedContextData);


This line never failed-unnecessary checks.

2chanhaeng · 2026-08-08T17:36:12Z

+  const handler = integrateHandler(mockFederation, createContextData);
+  await handler(ctx);
+
+  assertEquals(receivedContextData, expectedContextData);


This line also never failed.

Thank you for the detailed feedback :D

rewrite0w0 and others added 4 commits August 6, 2026 15:57

Verify onNotFound wires to ctx.next() in @fedify/fresh (fedify-dev#863)

8ec50a9

Assisted-by: Gemini:3.0

Verify onNotAcceptable handles 404 and non-404 in @fedify/fresh (fedi…

f285d37

…fy-dev#864) Assisted-by: Gemini:3.0

Verify integrateHandler passes context data in @fedify/fresh (fedify-…

4e0a335

…dev#865) Assisted-by: Gemini:3.0

Merge branch 'fedify-dev:main' into test/fresh-integration-tests

dc5b53e

rewrite0w0 requested review from 2chanhaeng and dahlia as code owners August 8, 2026 07:24

coderabbitai Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread packages/fresh/src/mod.test.ts Outdated

Fix onNotFound receiver check in fedify/fresh test

13668e4

coderabbitai Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread packages/fresh/src/mod.test.ts Outdated

Use assertStrictEquals for request/response identity in fedify/fresh …

313f8af

…test

2chanhaeng requested changes Aug 8, 2026

View reviewed changes

rewrite0w0 added 4 commits August 9, 2026 03:41

Remove Korean comments from fedify/fresh test

78522e7

Add test task to fresh deno.json

75437d3

Fix strict equality checks and restore missing test in fedify/fresh test

685bb36

Fix strict equality checks and add missing tests in fedify/fresh

1232bc7

coderabbitai Bot mentioned this pull request Aug 9, 2026

Add an async context data test for @fedify/express #985

Open

3 tasks

rewrite0w0 requested a review from 2chanhaeng August 9, 2026 12:04

Navigation Menu

Uh oh!

Uh oh!

Add integration tests for packages/fresh/src/mod.ts (#863, #864, #865) - #988

Add integration tests for packages/fresh/src/mod.ts (#863, #864, #865)#988
rewrite0w0 wants to merge 10 commits into
fedify-dev:mainfrom
rewrite0w0:test/fresh-integration-tests

rewrite0w0 commented Aug 8, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Aug 8, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 8, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

2chanhaeng left a comment •

edited

Loading

Uh oh!

2chanhaeng Aug 8, 2026

Uh oh!

2chanhaeng Aug 8, 2026

Uh oh!

rewrite0w0 Aug 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

rewrite0w0 commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Background

Changes

Testing

AI assistance

Uh oh!

netlify Bot commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fedify-json-schema canceled.

Uh oh!

coderabbitai Bot commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

2chanhaeng left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

2chanhaeng Aug 8, 2026

Choose a reason for hiding this comment

Uh oh!

2chanhaeng Aug 8, 2026

Choose a reason for hiding this comment

Uh oh!

rewrite0w0 Aug 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rewrite0w0 commented Aug 8, 2026 •

edited

Loading

netlify Bot commented Aug 8, 2026 •

edited

Loading

coderabbitai Bot commented Aug 8, 2026 •

edited

Loading

2chanhaeng left a comment •

edited

Loading