Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

### Bug Fixes:

- fix(service-version): support autoclone when staging a service version. ([#1850](https://github.com/fastly/cli/pull/1850))

### Enhancements:

### Dependencies:
Expand Down
20 changes: 20 additions & 0 deletions pkg/commands/service/version/serviceversion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,26 @@ func TestVersionStage(t *testing.T) {
EnvVars: map[string]string{"FASTLY_SERVICE_ID": ""},
WantError: "error parsing arguments: required flag --version not provided",
},
{
Name: "validate --autoclone stages a clone of an active version",
Args: "--service-id 123 --version 1 --autoclone",
API: &mock.API{
GetVersionFn: testutil.GetVersion,
CloneVersionFn: testutil.CloneVersionResult(4),
ActivateVersionFn: stageVersionOK,
},
WantOutput: "Staged service 123 version 4",
},
{
Name: "validate --autoclone stages a clone of a locked version",
Args: "--service-id 123 --version 2 --autoclone",
API: &mock.API{
GetVersionFn: testutil.GetVersion,
CloneVersionFn: testutil.CloneVersionResult(4),
ActivateVersionFn: stageVersionOK,
},
WantOutput: "Staged service 123 version 4",
},
{
Args: "--service-id 123 --version 3",
API: &mock.API{
Expand Down
6 changes: 6 additions & 0 deletions pkg/commands/service/version/stage.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type StageCommand struct {
Input fastly.ActivateVersionInput
serviceName argparser.OptionalServiceNameID
serviceVersion argparser.OptionalServiceVersion
autoClone argparser.OptionalAutoClone
}

// NewStageCommand returns a usable command registered under the parent.
Expand All @@ -45,6 +46,10 @@ func NewStageCommand(parent argparser.Registerer, g *global.Data) *StageCommand
Dst: &c.serviceVersion.Value,
Required: true,
})
c.RegisterAutoCloneFlag(argparser.AutoCloneFlagOpts{
Action: c.autoClone.Set,
Dst: &c.autoClone.Value,
})
return &c
}

Expand All @@ -53,6 +58,7 @@ func (c *StageCommand) Exec(_ io.Reader, out io.Writer) error {
serviceID, serviceVersion, err := argparser.ServiceDetails(argparser.ServiceDetailsOpts{
Active: optional.Of(false),
Locked: optional.Of(false),
AutoCloneFlag: c.autoClone,
APIClient: c.Globals.APIClient,
Manifest: *c.Globals.Manifest,
Out: out,
Expand Down
Loading