Skip to content

Add use-bits option for network bandwidth - #541

Open
vjr wants to merge 1 commit into
mainfrom
vishal/network-use-bits-option
Open

Add use-bits option for network bandwidth#541
vjr wants to merge 1 commit into
mainfrom
vishal/network-use-bits-option

Conversation

@vjr

@vjr vjr commented Aug 25, 2026

Copy link
Copy Markdown
Member

Option to display network speeds in bits-per-second instead of bytes.

Option to display network speeds in bits-per-second instead of bytes.
@vjr vjr self-assigned this Aug 25, 2026
@vjr
vjr requested review from a team and stsdc August 25, 2026 03:35
@vjr vjr mentioned this pull request Aug 25, 2026
@vjr
vjr requested a review from danirabbit August 25, 2026 03:49

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format size takes flags so you don't need to create a new util for this https://valadoc.org/glib-2.0/GLib.FormatSizeFlags.html

Does this also really need to be an option? Is this a case where this would just be the better way to format it?

@vjr

vjr commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Format size takes flags so you don't need to create a new util for this https://valadoc.org/glib-2.0/GLib.FormatSizeFlags.html

Does this also really need to be an option? Is this a case where this would just be the better way to format it?

I added the util because glib only returns the size without the "per second" (actually abbreviated to just "ps") portion, eg. "123 bytes" or "123 MB" while this util shows "123 bps" or "123 MBps". It's intended mainly for file sizes I guess? Can we keep this new util?

I see your localization comment in the other PR - can we leave this for another PR?

I'm in favour of just defaulting to "bits per second" and remove the option/checkbox because network bandwidth is usually seen this way, advertised by ISPs this way etc. but I remember when I sent a PR to KDE there was some user contention from those who prefer bytes, maybe it's a local/regional thing?

CC @stsdc looking forward to your feedback too.

@vjr
vjr requested a review from danirabbit August 25, 2026 05:02
@danirabbit

Copy link
Copy Markdown
Member

I think maybe we should just switch it to bits and see if anyone complains before adding a setting

But I think we need to do proper localization here and not regress on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants