feat(control): Add CPUs number to GetHostResource RPC reply - #48
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
azenla
reviewed
Jul 28, 2026
| uint32 hypervisor_numa_nodes = 6; | ||
| uint32 hypervisor_cpu_sockets = 7; | ||
| uint32 hypervisor_cpu_cores = 8; | ||
| uint32 hypervisor_threads_per_core = 17; |
Member
There was a problem hiding this comment.
I've seen threads per core and cores per socket but I think it's technically possible for these to be incorrect these days due to asymmetric Intel CPUs where Efficiency cores have 1 thread and performance cores have two, maybe we should replace threads per core and cores per socket with just hypervisor_cpu_threads which should then be equal to hypervisor_nr_cpus.
So maybe we can replace all of these with hypervisor_cpu_threads?
Contributor
Author
There was a problem hiding this comment.
Done in next revision.
We extend GetHostResourceReply to include CPUs threads number. This value is conceptually the same as the one reported by `nproc` on Linux systems and it represents the maximum number of CPUs to which a vCPU can be pinned. Signed-off-by: Costin Lupu <costin@edera.dev>
clupuishere
force-pushed
the
costin/vcpu-pin-03
branch
from
July 28, 2026 16:51
a3f4091 to
547a2d4
Compare
azenla
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We extend GetHostResourceReply to include CPUs threads number. This value is conceptually the same as the one reported by
nprocon Linux systems and it represents the maximum number of CPUs to which a vCPU can be pinned.