chore: Modify arm64 instruction formatter and cleanup code for arm64 disassembler - #3240
Open
filzrev wants to merge 4 commits into
Open
chore: Modify arm64 instruction formatter and cleanup code for arm64 disassembler#3240filzrev wants to merge 4 commits into
filzrev wants to merge 4 commits into
Conversation
filzrev
force-pushed
the
chore-modify-arm64-instruction-formatter
branch
from
August 25, 2026 06:40
a6f4d72 to
c9df920
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains following changes.
Arm64InstructionFormatter.csModify existing
PadLeftlogics to insert spaces at least 1.On existing implementation, When specifying
FirstOperandCharIndexvalue is lower than Mnemonic length.First operand is outputted without space between mnemonic.
Arm64Disassembler.csMove
RegisterValueAccumulatorstruct to separated file.And rename to
Arm64RegisterValueAccumulator.Arm64RegisterValueAccumulator.csModify code that using
ClrRuntimetoIClrRuntime.This changes are needed to write unit tests for ValueAccumulator.