chore: Modify csproj-based project build logics - #3235
Conversation
|
I've re-enable Because it cause following errors for
It seems occurred because |
|
Wasm related CI tests are still failed when using |
|
It seems that xUnit v2 is incompatible with wasm. It's probably fixed by #3232. |
This issue is caused commit 7f18102 is not pushed to target CI branch. And I've added following commits to avoid issue when using |
20fc0fe to
75973bf
Compare
|
By changing some settings. CI: https://github.com/filzrev/BenchmarkDotNet/actions/runs/32571372114/workflow |
This PR intended to fix #3191.
What's changed in this PR
1. Cherry picks other PR commits
Following PR contents are included
2. Remove DllGatherer related logics
After this PR changes, DllGatherer logics seems not be needed.
So I've removed DllGatherer related logics.
3. Add settings for Autogenerated project.
Modify
BenchmarkDotNet.Build.props.txttemplate.And enable following settings for Autogenerated project.
OutputPathPublishDir4. Cleanup
DotNetCliCommand.cslogics.Previously,
--outputand-p:PublishDircommand line parameters are used.These settings are handled as MSBuild Global property and that causing DoubleWrite Issues.
So this PR move these settings to Autogenerated.csproj level.
other projects build outputs are placed under
.artifactsdirectory.4. Other Changes
ErrorOnDuplicatePublishOutputFilessettings.XmlDocument.SaveAsynchelper method for netstandard2.0Test
Setting
ForcedNoDependenciesForIntegrationTests: falseversion of CI. (InProgress)