fix(docker): drop obsolete enableNonRootDocker option for docker-in-d…

[V-Subhankar-infy]

Title

Remove stale Docker in Docker option wiring and update Helm smoke test compatibility

Problem

A stale template option, enableNonRootDocker, was still being surfaced and forwarded in places that use the Docker in Docker feature. The current Docker in Docker feature option set does not include this option.
The Same was reported at devcontainers/features#1618

This mismatch caused two issues:

1. Configuration drift between template options and feature options.
2. Confusing behavior for users who see an option that is not actually supported by the underlying feature.

During validation, one smoke test also failed for an unrelated compatibility reason: the Helm command in the Kubernetes Minikube test used helm version --client, which is not supported by current Helm releases.

Fix Summary

This change removes stale enableNonRootDocker usage only where it is tied to Docker in Docker, keeps valid usage for Docker outside of Docker intact, and updates one test command for Helm CLI compatibility.

Specifically:

1. Removed enableNonRootDocker from the Docker in Docker template option list.
2. Removed forwarding of enableNonRootDocker to the Docker in Docker feature in template devcontainer configs.
3. Updated generated template documentation to remove the stale option row.
4. Removed stale Docker in Docker option usage from Kubernetes Minikube template configuration.
5. Updated Kubernetes Minikube smoke test to use helm version --short.
6. Bumped template patch versions for changed templates.

Tests

Smoke tests were run for both affected templates using the same local harness flow in both the affected repos- docker-in-docker & kubernetes-helm-minikube.

Impact

This change improves correctness and clarity of template configuration.

User impact:

1. Users no longer see or pass a stale Docker in Docker option that is unsupported by the feature.
2. Kubernetes Minikube smoke tests remain green on current Helm versions.
3. Valid enableNonRootDocker usage for Docker outside of Docker remains unchanged.

[Copilot]

Pull request overview

This PR updates the Docker-in-Docker–based templates to remove the now-obsolete enableNonRootDocker template option and adjusts the Kubernetes/Helm/Minikube test script to use a Helm CLI invocation compatible with current Helm versions.

Changes:

• Remove enableNonRootDocker from the Docker in Docker template’s options, generated .devcontainer.json, and README.
• Remove enableNonRootDocker from the Kubernetes - Minikube-in-Docker template’s .devcontainer.json.
• Update the Helm smoke test to use helm version --short and bump template patch versions.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/kubernetes-helm-minikube/test.sh	Updates Helm version check to a modern, compatible CLI flag set.
src/kubernetes-helm-minikube/devcontainer-template.json	Bumps template patch version to reflect the config change.
src/kubernetes-helm-minikube/.devcontainer/devcontainer.json	Drops the obsolete feature option from the Docker-in-Docker feature config.
src/docker-in-docker/README.md	Removes the obsolete option from documented template options.
src/docker-in-docker/devcontainer-template.json	Removes the obsolete option from the template’s declared options and bumps patch version.
src/docker-in-docker/.devcontainer/devcontainer.json	Stops passing the removed template option into the Docker-in-Docker feature.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.