Skip to content

Added import code review agent skill - #2160

Open
rohitkumarbhagat wants to merge 11 commits into
datacommonsorg:masterfrom
rohitkumarbhagat:code-review-agent
Open

Added import code review agent skill#2160
rohitkumarbhagat wants to merge 11 commits into
datacommonsorg:masterfrom
rohitkumarbhagat:code-review-agent

Conversation

@rohitkumarbhagat

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new agent skills, prompts, and documentation for Data Commons import code reviews, review-signal mining, and signal merging, along with contract tests for the code review skill. The review feedback identifies three important issues: the newly added dc-import-review-signal-miner skill needs to be registered in .agents/skills.json, corresponding contract tests should be added for this new skill in skill_contract_test.py, and the GitHub REST API version specified in the miner's instructions must be corrected from 2026-03-10 to the supported 2022-11-28 to avoid API failures.

Comment thread .agents/skills.json
Comment thread agents/common/scripts/skill_contract_test.py
Comment thread agents/skills/dc-import-review-signal-miner/SKILL.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant