Skip to content

[SSH] Add base environment presence telemetry#6058

Open
rclarey wants to merge 2 commits into
mainfrom
base-env-and-usage-policy-telem
Open

[SSH] Add base environment presence telemetry#6058
rclarey wants to merge 2 commits into
mainfrom
base-env-and-usage-policy-telem

Conversation

@rclarey

@rclarey rclarey commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Changes

Add has_base_environment to SSH telemetry events

Why

To understand usage

Tests

Automated tests added

@rclarey
rclarey marked this pull request as ready for review July 24, 2026 09:13
@github-actions

Copy link
Copy Markdown
Contributor

Approval status: pending

/libs/telemetry/ - needs approval

Files: libs/telemetry/protos/ssh_tunnel.go
Suggested: @simonfaltum
Also eligible: @Divyansh-db, @renaudhartert-db, @hectorcast-db, @parthban-db, @tanmay-db, @tejaskochar-db, @mihaimitrea-db, @chrisst, @rauchy

General files (require maintainer)

Files: experimental/ssh/internal/client/client.go, experimental/ssh/internal/client/client_internal_test.go
Based on git history:

  • @anton-107 -- recent work in experimental/ssh/internal/client/, libs/telemetry/protos/

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db) can approve all areas.
See OWNERS for ownership rules.

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: c13cdff

Run: 30081815466

Env 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
💚​ aws linux 4 4 322 1059 10:43
💚​ aws windows 4 4 324 1057 7:46
💚​ azure linux 4 4 322 1058 7:25
💚​ azure windows 4 4 324 1056 6:23
💚​ gcp linux 1 5 321 1060 8:56
💚​ gcp windows 1 5 323 1058 7:40
8 interesting tests: 4 RECOVERED, 4 SKIP
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/bundle/invariant/no_drift 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
💚​ TestFetchRepositoryInfoAPI_FromRepo 💚​R 💚​R 💚​R 💚​R 🙈​S 🙈​S
💚​ TestFetchRepositoryInfoAPI_FromRepo/root 💚​R 💚​R 💚​R 💚​R
💚​ TestFetchRepositoryInfoAPI_FromRepo/subdir 💚​R 💚​R 💚​R 💚​R
Top 8 slowest tests (at least 2 minutes):
duration env testname
3:24 azure windows TestAccept
3:20 aws windows TestAccept
3:19 gcp windows TestAccept
3:07 gcp windows TestFilerWorkspaceFilesExtensionsDelete
2:35 aws windows TestAccept/bundle/deploy/mlops-stacks/DATABRICKS_BUNDLE_ENGINE=direct
2:21 aws windows TestImportDir
2:20 azure windows TestAccept/bundle/deploy/mlops-stacks/DATABRICKS_BUNDLE_ENGINE=terraform
2:12 gcp linux TestAccept/bundle/deploy/mlops-stacks/DATABRICKS_BUNDLE_ENGINE=terraform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants