Tag genie ask requests with databricks_cli source and disable viz#5988
Closed
yansonggao-db wants to merge 3 commits into
Closed
Tag genie ask requests with databricks_cli source and disable viz#5988yansonggao-db wants to merge 3 commits into
yansonggao-db wants to merge 3 commits into
Conversation
Contributor
Author
|
@lennartkats-db this is the CLI side of the Genie-One-in-CLI work — |
lennartkats-db
requested changes
Jul 21, 2026
yansonggao-db
force-pushed
the
genie-source-and-viz
branch
from
July 21, 2026 15:54
ab82edf to
f64d9e2
Compare
lennartkats-db
approved these changes
Jul 21, 2026
`databricks experimental genie ask` now sends a `source: "databricks_cli"` field on the OneChat /responses request so the backend can attribute CLI traffic distinctly (vs webapp/Slack/MCP), and sends `enable_viz: false` because the CLI renders in a terminal that cannot display charts. - GenieRequest gains Source (string) and EnableViz (*bool, so false serializes past omitempty) fields. - BuildRequest sets both unconditionally; neither is user-configurable. - Updates the wire-format test and adds a test pinning both fields.
yansonggao-db
force-pushed
the
genie-source-and-viz
branch
from
July 21, 2026 22:15
f64d9e2 to
72a1f44
Compare
Contributor
|
✅ approved, recreating here for CI purposes => #6056 |
renaudhartert-db
approved these changes
Jul 24, 2026
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
lennartkats-db
enabled auto-merge
July 24, 2026 09:03
Contributor
|
✅ merged via #6056, thanks again! |
auto-merge was automatically disabled
July 24, 2026 09:32
Pull request was closed
dustinvannoy-db
pushed a commit
to dustinvannoy-db/cli
that referenced
this pull request
Jul 24, 2026
…tabricks#6056) _Re-home of databricks#5988 (fork PR by @yansonggao-db) onto an in-repo branch so CI can run; reviewed and approved by @lennartkats-db_ ## Changes `databricks experimental genie ask` now sets two fields on the OneChat `/responses` request it already sends: - `source: "databricks_cli"` so the backend attributes CLI-originated Genie traffic distinctly from webapp/Slack/MCP. - `enable_viz: false` because the CLI renders in a terminal that can't display charts, so it tells the agent to skip visualization tools. Neither is user-configurable; `BuildRequest` sets both unconditionally. `EnableViz` is a `*bool` so `false` serializes past `omitempty`. ## Why Backend traffic attribution: OneChat buckets conversations by `source`, and CLI traffic currently arrives untagged. Disabling viz avoids the agent emitting chart items the terminal can't render. ## Tests `go test ./libs/genie/...` passes. `TestBuildRequest_WireFormat` pins the new fields and `TestBuildRequest_TagsSourceAndDisablesViz` asserts `source` and `enable_viz:false` are always on the wire. Co-authored-by: Yansong Gao <yansong.gao@databricks.com> Co-authored-by: Yansong Gao <yansong.gao@databricks.com> Co-authored-by: Renaud Hartert <renaud.hartert@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
databricks experimental genie asknow sets two fields on the OneChat/responsesrequest it already sends:source: "databricks_cli"— so the backend attributes CLI-originated Genie traffic distinctly from webapp/Slack/MCP.enable_viz: false— the CLI renders in a terminal that can't display charts, so it tells the agent to skip visualization tools.Neither is user-configurable;
BuildRequestsets both unconditionally.EnableVizis a*boolsofalseserializes pastomitempty(a plainfalsewould be dropped, letting the backend default viz on).Why
Backend traffic attribution: OneChat buckets conversations by
source, and CLI traffic currently arrives untagged (bucketed as UNSPECIFIED). The matching backend enum + parsing already landed in the Databricks monorepo. Disabling viz avoids the agent emitting chart/plot items the terminal can't render.Tests
go test ./experimental/genie/...passes. UpdatedTestBuildRequest_WireFormatto pin the new fields and addedTestBuildRequest_TagsSourceAndDisablesVizassertingsourceandenable_viz:falseare always on the wire.