Fix #14883 fuzzing crash (null-pointer-use) in Tokenizer::findGarbageCode()#8692
Open
chrchr-github wants to merge 3 commits into
Open
Fix #14883 fuzzing crash (null-pointer-use) in Tokenizer::findGarbageCode()#8692chrchr-github wants to merge 3 commits into
chrchr-github wants to merge 3 commits into
Conversation
firewave
reviewed
Jul 3, 2026
| @@ -8962,6 +8962,8 @@ void Tokenizer::findGarbageCode() const | |||
| const Token* const endTok = tok->linkAt(1); | |||
| for (tok = tok->tokAt(2); tok != endTok; tok = tok->next()) { | |||
| if (const Token* lam = findLambdaEndTokenWithoutAST(tok)) { | |||
Collaborator
There was a problem hiding this comment.
If tok is nullptr this call would "fail" and thus we would still deref it below. IS this something to address or should we wait for fuzzed variant which will actually trigger that?
Collaborator
Author
There was a problem hiding this comment.
It should be fine for now since tok cannot be set to endTok anywhere else (findLambdaEndTokenWithoutAST() returns the Token after }).
precedes() cannot be used because token indices don't exist yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.