Add attended scripts for multi-branch UBI bump and module update PRs - #3430
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds two attended Bash scripts. One creates Go module upgrade pull requests across release branches. The other creates UBI base-image bump pull requests. Both validate repository state, process branches, push generated changes, create GitHub pull requests, and report results. ChangesGo module upgrade pull requests
UBI base-image bump pull requests
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The PR adds attended automation for UBI and Go module update pull requests; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant Operator
participant AutomationScript
participant Git
participant ExternalTools
participant GitHub
Operator->>AutomationScript: select module or image and branches
AutomationScript->>Git: validate state and fetch upstream
AutomationScript->>ExternalTools: run upgrade or image bump workflow
ExternalTools-->>AutomationScript: return update results
AutomationScript->>Git: commit and push generated branch
Git-->>AutomationScript: return push result
AutomationScript->>GitHub: create pull request
GitHub-->>AutomationScript: return pull request URL
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Summary by QodoAdd attended scripts to open multi-branch UBI and Go module update PRs
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
|
FYI I used this to generate these PRs:
Works pretty good afaict. |
|
🤖 Finished Review · ✅ Success · Started 3:13 PM UTC · Completed 3:27 PM UTC |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hack/ubi-bump-prs.sh`:
- Around line 172-176: Update the failed-push handling around the git push in
the script to distinguish non-fast-forward failures, fetch the current remote
state before retrying, and use an explicit --force-with-lease instead of -f. Do
not offer or perform an unconditional force push; preserve the existing prompt
and branch variables while ensuring collaborators’ remote commits cannot be
silently overwritten.
- Around line 140-145: In the declined-PR branch of the interactive loop, reset
the work branch to "$UPSTREAM_REMOTE/$BRANCH" before continuing so the bump’s
tracked changes are discarded and later git checkout -B operations can proceed.
Update the logic surrounding the answer check and preserve the existing skip
messages and continue behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 49eab71c-fba6-403c-b62d-d77c46e186ef
📒 Files selected for processing (1)
hack/ubi-bump-prs.sh
Code Review by Qodo
1.
|
![qodo-for-conforma[bot]](https://avatars.githubusercontent.com/in/3609154?s=60&v=4){kind=small}
ReviewFindingsMedium
Low
Previous runReviewFindingsLow
Previous run (2)ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (3)ReviewFindingsHigh
Low
Next steps:
Previous run (4)ReviewFindingsLow
Previous run (5)ReviewFindingsMedium
Low
Previous run (6)ReviewFindingsMedium
Low
Next steps:
Previous run (7)ReviewFindingsMedium
Low
Next steps:
Previous run (8)ReviewFindingsMedium
Low
Previous run (9)ReviewFindingsMedium
Low
Labels: PR adds developer automation tooling in hack/ for UBI base image management |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
requires-manual-review
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c48f604 to
a3090fb
Compare
|
🤖 Finished Review · ✅ Success · Started 1:27 PM UTC · Completed 1:44 PM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Moving to draft while I look at the fullsend comments. |
Pull request was converted to draft
a3090fb to
af44b7c
Compare
|
🤖 Finished Review · ✅ Success · Started 5:19 PM UTC · Completed 5:35 PM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
removed
the
requires-manual-review
af44b7c to
0d74c14
Compare
|
🤖 Finished Review · ✅ Success · Started 8:49 PM UTC · Completed 9:06 PM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
0d74c14 to
09fa222
Compare
fullsend-ai-review
Bot
removed
the
ready-for-merge
747be31 to
99d515b
Compare
|
🤖 Finished Review · ✅ Success · Started 7:40 PM UTC · Completed 7:58 PM UTC Commit: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
99d515b to
10c895b
Compare
|
🤖 Finished Review · ✅ Success · Started 8:17 PM UTC · Completed 8:34 PM UTC Commit: |
Superseded by updated review
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
the
ready-for-merge
st3penta
left a comment
st3penta
left a comment
There was a problem hiding this comment.
looks good, just one minor suggestion
10c895b to
e071a15
Compare
|
🤖 Review · Commit: |
|
🤖 Finished Review · ✅ Success · Started 6:24 PM UTC · Completed 6:42 PM UTC Commit: |
fullsend-ai-review
Bot
added
requires-manual-review
|
/retest |
Wraps existing scripts hack/ubi-base-image-bump.sh and hack/go-mod-upgrade-helper.sh to automate creating PRs for all active branches. For the ubi bump, we look inside the old and new base images to compare rpm versions, and include that in the commit. The goal is to make it easier and faster to upgrade ubi base images and golang deps across all active branches, usually in response to a CVE scan notification. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e071a15 to
ca0bd45
Compare
st3penta
left a comment
st3penta
left a comment
There was a problem hiding this comment.
Couldn't be more polished than this 😆
|
🤖 Finished Retro · ✅ Success · Started 8:39 AM UTC · Completed 8:59 AM UTC Commit: |
Retro: PR #3430 — Add attended scripts for multi-branch UBI bump and module update PRsOverall assessment: The fullsend review agent provided substantial value on this PR, catching 3 high-severity runtime-breaking bugs that no other agent or human reviewer found. However, the dominant negative pattern was persistent repetition of 4–5 low-severity findings across 8–10 review rounds despite explicit author rejection, causing visible review fatigue. Timeline
What went well
What could go better
Evidence for existing open issues
Proposals1 proposal filed (see below). The core repeated-findings problem is well-covered by existing agent-layer issues; the repo-level signal gap is not. Proposals filed |
2 participants
Summary
hack/ubi-bump-prs.sh, an attended script that creates UBI base image bump PRs across all active release brancheshack/ubi-base-image-bump.shand adds RPM version diffing (viapodman run rpm -qa) in both the commit message and PR bodyRef: https://redhat.atlassian.net/browse/EC-2120