Skip to content

fix(#5525): Make StatusInfo payload respect the sorting coming from the health payload for the provided details#5526

Open
cdprete wants to merge 1 commit into
codecentric:masterfrom
cdprete:fix/5525
Open

fix(#5525): Make StatusInfo payload respect the sorting coming from the health payload for the provided details#5526
cdprete wants to merge 1 commit into
codecentric:masterfrom
cdprete:fix/5525

Conversation

@cdprete

@cdprete cdprete commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #5525

@cdprete cdprete requested a review from a team as a code owner July 13, 2026 11:32
@cdprete cdprete marked this pull request as draft July 13, 2026 11:35
@cdprete cdprete force-pushed the fix/5525 branch 3 times, most recently from 91492e3 to 227c5ac Compare July 13, 2026 12:16
@cdprete

cdprete commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@SteKoe @ulischulte I don't know if we want to make it a TreeMap instead of LinkedHashMap.

TreeMap would allow to ensure they're always in order, but I would like to hear your opinion instead of just changing it.
For what I can see with the debugger enabled, the Map<String, ?> that gets extracted is already a LinkedHashMap and that's why I kept the same, but I'm a bit tempted to changed it to TreeMap to ensure there is always a proper sorting.

It's currently in draft because I need to test this with my own laptop.
Somehow now I've different issues on my company laptop where esbuild gets blocked and, therefore, I can't even do npm install

@cdprete cdprete force-pushed the fix/5525 branch 2 times, most recently from 2a5eeb2 to 77e4eb7 Compare July 14, 2026 17:28
…ming from the health payload for the provided details
@cdprete cdprete marked this pull request as ready for review July 14, 2026 17:29
@cdprete

cdprete commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Tested locally and the sorting is now indeed preserved:
image

I also took the chance to extend an existing test in StatusInfoTest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Status update payload doesn't respect the sorting of the health payload

1 participant