Remove CD-ROM from block devices - #485
Conversation
Cristi1324
commented
Aug 4, 2026
Cristi1324
commented
| MAJOR_COLUMN_INDEX = 4 | ||
|
|
||
| # lsblk TYPE values that are not migration volumes (CD-ROM, loopback, etc.). | ||
| _NON_VOLUME_BLOCK_DEVICE_TYPES = frozenset({"part", "rom", "loop"}) |
There was a problem hiding this comment.
hm, considering that we don't migrate loopback devices in the first place, I wonder how "loop" can be encountered during OS morphing.
There was a problem hiding this comment.
Maybe instead of filtering out the types, filter in?
| _NON_VOLUME_BLOCK_DEVICE_TYPES = frozenset({"part", "rom", "loop"}) | |
| _VOLUME_BLOCK_DEVICE_TYPES = frozenset({"disk", "part"}) |
if (len(parts) >= 2
and parts[1] in _VOLUME_BLOCK_DEVICE_TYPES):
volume_devs.append("/dev/%s" % parts[0])There was a problem hiding this comment.
Actually that method should return only disk block devices. So only return disk types.
There was a problem hiding this comment.
hm, considering that we don't migrate loopback devices in the first place, I wonder how
"loop"can be encountered during OS morphing.
No, but the lsblk command returns the devices available on the minion, so it apperently returns the loop devices on the minion machine. Not sure why it does that, iirc this didn't happen in the past.
3 participants
