fix(settings): stop the team picker from squeezing the account list - #231
fix(settings): stop the team picker from squeezing the account list#231ye4241 wants to merge 1 commit into
Conversation
The team picker had the default `Shrink` width, so once the teams finished loading its full name (e.g. "Company Name (TEAMID)") grew the picker and left almost no room for the account button next to it. Give the picker `Fill` as well, so it splits the row evenly with the account button and its width no longer depends on the loaded team name.
|
You know you could've done this without an AI making a PR for you, right? It's a single line change |
|
Fair enough — yes, the fix was written with AI. I did build it and check the settings screen locally before opening the PR (the before/after screenshots are from that run), so it wasn't a blind patch. On the actual choice of width: my first thought was a 2:1 split in favour of the account button, but that leaves the picker too narrow — some team names get really long once they finish loading, so they would still be squeezed. That is exactly why I opened this PR with an even 1:1 split instead. I also considered 1:2 (giving the picker two thirds), but that felt a little too wide. If you prefer 1:2, I am happy to change it — or to close this and let you apply the one-liner yourself. |
What
The team picker in the settings screen used the default
Shrinkwidth. Once the teams finished loading, the picker resized itself to fit the full team name (e.g.Company Name (TEAMID)), which ate the row and left almost no space for the account button next to it — the account email ended up wrapped into a narrow column.This also meant the row jumped around: the picker was narrow while it only showed the team ID placeholder, then suddenly grew wide once the names arrived.
How
Give the picker
Fillas well, so it shares the row evenly with the account button and its width no longer depends on the length of the loaded team name.Screenshots
Before:
After:
Testing
cargo check -p plumeimpactor/cargo build --bin plumeimpactor(macOS, aarch64) — clean.Chengdu iSlide Network Technology Co., Ltd. (…)); the account button keeps its half of the row and no longer resizes when the teams finish loading.