any(): Do not rip fusion inputs - #7151
Open
mattnibs wants to merge 1 commit into
Open
Conversation
nwt
reviewed
Jul 27, 2026
mattnibs
force-pushed
the
any-no-rip
branch
2 times, most recently
from
July 27, 2026 21:43
97721a6 to
84cbd96
Compare
nwt
approved these changes
Jul 28, 2026
| case vector.KindFusion: | ||
| return firstNonNullSlot(vector.Super(vec)) | ||
| case vector.KindUnion: | ||
| union := vec.(*vector.Union) |
Member
There was a problem hiding this comment.
Does this need to handle vector.Const?
Collaborator
Author
There was a problem hiding this comment.
as in a Const where the value is null or a Const union?
Member
There was a problem hiding this comment.
vector.Const containing a vector.Union.
This commit fixes an issue with the any aggregator where fusion values were not getting perserved. It also adds vector.NoRip to aggregator aggExprs because this was also ripping fusion values where we do not want them to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with the any aggregator where fusion values were not getting perserved. It also adds vector.NoRip to aggregator aggExprs because this was also ripping fusion values where we do not want them to.
Fixes #6897