Add optional dissipation for Div_par_mod in Fci - #3467
Open
totork wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@dschwoerer Added the exception when it is not Fci |
dschwoerer
reviewed
Aug 21, 2026
| Coordinates* coord = f_in.getCoordinates(); | ||
| ASSERT1_FIELDS_COMPATIBLE(f_in, v_in); | ||
|
|
||
| if (!f_in.isFci() && dissipative) { |
Contributor
There was a problem hiding this comment.
If you move this to the non FCI branch, it will be just
Suggested change
| if (!f_in.isFci() && dissipative) { | |
| if (dissipative) { |
dschwoerer
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Div_par_mod operator does not have any dissipation added in Fci. This PR adds a Rusanov flux. It is optional, so that it can be turned off in physics models for e.g. testing/MMS purposes.
Used to be
#3466
but now on the boutproject repo.