[ZEPPELIN-6436] Fix stale module names and test commands in embedding search documentation - #5408
Merged
tbonelee merged 2 commits intoAug 9, 2026
Conversation
tbonelee
requested changes
Aug 9, 2026
tbonelee
left a comment
tbonelee
left a comment
Contributor
There was a problem hiding this comment.
Could you also replace the zeppelin-zengine text in EmbeddingSearchTest.java?
gjenfwo
force-pushed
the
ZEPPELIN-6436-fix-embedding-search-docs
branch
from
August 9, 2026 16:15
9beb6e0 to
fe0aaca
Compare
… search documentation [ZEPPELIN-6436] Fix stale module names and test commands in embedding search documentation docs/embedding-search.md still referenced the zeppelin-zengine module, which was merged into zeppelin-server (ZEPPELIN-6355) before the embedding search feature was added. Update implementation paths, the pom.xml reference, and the mvn test -pl commands to zeppelin-server so the documented commands actually work.
gjenfwo
force-pushed
the
ZEPPELIN-6436-fix-embedding-search-docs
branch
from
August 9, 2026 16:24
fe0aaca to
3a6ae48
Compare
… search documentation + missed one earlier, added one more change. [ZEPPELIN-6436] Fix stale module names and test commands in embedding search documentation docs/embedding-search.md still referenced the zeppelin-zengine module, which was merged into zeppelin-server (ZEPPELIN-6355) before the embedding search feature was added. Update implementation paths, the pom.xml reference, and the mvn test -pl commands to zeppelin-server so the documented commands actually work.
Contributor
Author
Thanks for pointing this out. I missed it earlier and added one more change to update the reference in |
tbonelee
approved these changes
Aug 9, 2026
Contributor
|
Merged into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
docs/embedding-search.mdstill referenced thezeppelin-zenginemodule, which was merged intozeppelin-serverin ZEPPELIN-6355 before the embedding search feature was added in ZEPPELIN-6411. As a result, the implementation paths and themvn test -pl zeppelin-zenginecommands in the doc no longer match the current repository layout and the test commands fail as written. This PR updates the stale references so the documentation is accurate and the test commands actually run.What type of PR is it?
Documentation
Todos
zeppelin-zenginereferences withzeppelin-serverin implementation pathsmvn test -plcommands to targetzeppelin-serverWhat is the Jira issue?
ZEPPELIN-6436
How should this be tested?
Confirm no stale references remain:
rg -n "zeppelin-zengine" docs/embedding-search.mdOptionally
Confirm the corrected paths exist in the repo:
zeppelin-server/src/main/java/org/apache/zeppelin/search/EmbeddingSearch.javazeppelin-server/src/test/java/org/apache/zeppelin/search/EmbeddingSearchTest.javazeppelin-server/src/test/java/org/apache/zeppelin/search/LuceneSearchTest.javaRun the corrected commands to confirm they work:
mvn test -pl zeppelin-server -Dtest=LuceneSearchTestZEPPELIN_EMBEDDING_TEST=true mvn test -pl zeppelin-server -Dtest=EmbeddingSearchTestScreenshots (if appropriate)
N/A
Questions: