PARQUET: Verify LICENSE and NOTICE in published JARs in CI - #3689
Merged
Fokko merged 1 commit intoJul 27, 2026
Merged
Conversation
5 tasks
kevinjqliu
changed the title
Contributor
|
@kevinjqliu Thanks for this PR, I've merged #3686, could you rebase this one? |
kevinjqliu
force-pushed
the
kevinjqliu/codex-verify-jar-legal-files
branch
from
July 27, 2026 18:46
fb225a0 to
fcd2ae9
Compare
Fokko
marked this pull request as ready for review
July 27, 2026 19:44
Fokko
approved these changes
Jul 27, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Thanks @kevinjqliu, checking if the files are present is a step into the right direction 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Part of #3687
Validate that all jars contain LICENSE and NOTICE files using
.github/workflows/ci-hadoop3.ymlBefore this change, the
.github/workflows/ci-hadoop3.yml's Java 17 CI job took about 25 minutes.What changes are included in this PR?
Add CI check to validate all jars contain LICENSE and NOTICE files
Are these changes tested?
Yes, tested manually and using CI.
In CI,
.github/workflows/ci-hadoop3.yml's Java 17 CI job currently fails because the jars are still missing LICENSE and NOTICE files (this branch does not yet include #3686). Will rebase and CI should be green.Are there any user-facing changes?
No