Add mutual SSL support for pipe sinks#18080
Open
Caideyipi wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the pipe thrift SSL sink path to support mutual SSL authentication, following the general thrift client mTLS support added in #18026.
Changes
sink.ssl.key-store-pathsink.ssl.key-store-pwdconnector.ssl.key-store-pathconnector.ssl.key-store-pwdiotdb-thrift-ssl-sink/iotdb-thrift-ssl-connectorread both sink and connector SSL aliases for:IoTDBSslSyncSinkIoTDBSyncClientManagerIoTDBSyncClientSessionPool.ssl.key-store-pwdin pipe parameter value masking.Tests
ssl.key-store-pwdvalue hiding.IoTDBPipeMutualSSLITstarts a receiver with thrift SSL client auth enabled, creates aniotdb-thrift-ssl-sinkpipe with trust/key stores, and verifies pipe data transfer through a mutual-SSL receiver.Local Verification
mvn -Ddevelocity.off=true spotless:apply -pl iotdb-api/pipe-api,iotdb-core/datanode,iotdb-core/confignode,integration-test -P with-integration-testsgit diff --checkI also attempted targeted UT execution with
mvn -Ddevelocity.off=true test -pl iotdb-api/pipe-api -Dtest=PipeParametersTest ..., but the local Windows environment failed to start/continue the JVM due to native memory/pagefile exhaustion (There is insufficient memory for the Java Runtime Environment to continue). The same environment issue also affected broader compile/test attempts.